Re: [PATCH v6 1/2] usb: typec: USB Type-C Port Manager (tcpm)
From: Greg Kroah-Hartman
Date: Thu Apr 27 2017 - 02:27:00 EST
On Wed, Apr 26, 2017 at 06:15:08PM -0700, Guenter Roeck wrote:
> On Wed, Apr 26, 2017 at 03:26:11PM -0700, Guenter Roeck wrote:
> > From: Guenter Roeck <groeck@xxxxxxxxxxxx>
> >
> > This driver implements the USB Type-C Power Delivery state machine
> > for both source and sink ports. Alternate mode support is not
> > fully implemented.
> >
> > The driver attaches to the USB Type-C class code implemented in
> > the following patches.
> >
> > usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY
> > usb: USB Type-C connector class
> >
> > This driver only implements the state machine. Lower level drivers are
> > responsible for
> > - Reporting VBUS status and activating VBUS
> > - Setting CC lines and providing CC line status
> > - Setting line polarity
> > - Activating and deactivating VCONN
> > - Setting the current limit
> > - Activating and deactivating PD message transfers
> > - Sending and receiving PD messages
> >
> > The driver provides both a functional API as well as callbacks for
> > lower level drivers.
> >
> > Signed-off-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> Of course this has missing dependencies and won't compile if CONFIG_DEBUG_FS
> is not enabled. Greg, should I send v7 or follow-up patches ?
v7 would be good to keep the kbuild bot happy :)
thanks,
greg k-h