Re: [PATCH] mtd: spi-nor: stm32: remove broken MODULE_ALIAS

[Ludovic BARRE]

thanks a lot Arnd

Oops, I've not tested in Module :-(.
Just tested in built-in, and used bind/unbind and device tree overlays.

BR
Ludo
On 04/27/2017 01:09 PM, Arnd Bergmann wrote:
> The MODULE_ALIAS statement refers to a macro that has never been defined
> in this driver, causing a build error:
>
> drivers/mtd/spi-nor/stm32-quadspi.c:694:150: error: expected ',' or ';' before 'DRIVER_NAME'
>
> Unless there is a specific alias we need other then the driver name,
> we don't need an alias here and can simply remove the line to fix the
> build.
>
> Fixes: dc5e400611c5 ("mtd: spi-nor: add driver for STM32 quad spi flash controller")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>   drivers/mtd/spi-nor/stm32-quadspi.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/stm32-quadspi.c b/drivers/mtd/spi-nor/stm32-quadspi.c
> index 90d9152ddf98..1056e7408d2a 100644
> --- a/drivers/mtd/spi-nor/stm32-quadspi.c
> +++ b/drivers/mtd/spi-nor/stm32-quadspi.c
> @@ -691,7 +691,6 @@ static struct platform_driver stm32_qspi_driver = {
>   };
>   module_platform_driver(stm32_qspi_driver);
>   
> -MODULE_ALIAS("platform:" DRIVER_NAME);
>   MODULE_AUTHOR("Ludovic Barre <ludovic.barre@xxxxxx>");
>   MODULE_DESCRIPTION("STMicroelectronics STM32 quad spi driver");
>   MODULE_LICENSE("GPL v2");