Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data

[Jiri Slaby]

Hi,

On 04/27/2017, 01:53 PM, Pavel Machek wrote:
>> @@ -91,11 +91,11 @@ ENDPROC(do_suspend_lowlevel)
>>  
>>  .data
>>  ALIGN
>> -ENTRY(saved_magic)	.long	0
>> -ENTRY(saved_eip)	.long	0
>> +SYM_DATA_SIMPLE(saved_magic, .long 0)
>> +SYM_DATA_SIMPLE_LOCAL(saved_eip, .long 0)
>>  
>>  # saved registers
>> -saved_idt:	.long	0,0
>> -saved_ldt:	.long	0
>> -saved_tss:	.long	0
>> +SYM_DATA_SIMPLE_LOCAL(saved_idt, .long 0,0)
>> +SYM_DATA_SIMPLE_LOCAL(saved_ldt, .long 0)
>> +SYM_DATA_SIMPLE_LOCAL(saved_tss, .long 0)
> 
> Do we really need to mark local data like that? It complicates the
> source code a bit...

Not really -- if the preferred way is not to annotate local symbols, I
can indeed remove that.

thanks,
-- 
js
suse labs

Attachment: signature.asc
Description: OpenPGP digital signature