Re: [PATCH] libnvdimm, pmem: fix badblocks notification crash

[Kani, Toshimitsu]

On Thu, 2017-04-27 at 15:26 -0700, Dan Williams wrote:
> On Thu, Apr 27, 2017 at 3:25 PM, Kani, Toshimitsu <toshi.kani@xxxxxxx
> > wrote:
> > On Thu, 2017-04-27 at 15:10 -0700, Dan Williams wrote:
> > > The nd_pmem_notify() routine is called whenever an ARS
> > > (address-range-scrub) completes to communicate results to the
> > > per-namespace badblocks instances.
> > > 
> > > When the namespace is in btt mode we crash because we do not
> > > allocate a struct pmem_device instance in that case. Resulting in
> > > the following crash signature:
> > > 
> > > ÂBUG: unable to handle kernel NULL pointer dereference at
> > > 0000000000000030
> > > ÂIP: nd_pmem_notify+0x30/0xf0 [nd_pmem]
> > > ÂCall Trace:
> > > Â nd_device_notify+0x40/0x50
> > > Â child_notify+0x10/0x20
> > > Â device_for_each_child+0x50/0x90
> > > Â nd_region_notify+0x20/0x30
> > > Â nd_device_notify+0x40/0x50
> > > Â nvdimm_region_notify+0x27/0x30
> > > Â acpi_nfit_scrub+0x341/0x590 [nfit]
> > > Â process_one_work+0x197/0x450
> > > Â worker_thread+0x4e/0x4a0
> > > Â kthread+0x109/0x140
> > > 
> > > Given that we don't even populate the btt badblocks instance,
> > > just return early and skip the device to region lookup.
> > 
> > We populate the btt badblocks into nsio->bb, and check/clear them
> > in nsio_rw_bytes().
> 
> Argh, yes, we don't populate them out to the disk badblocks. I'll go
> with your patch.

Thanks!
-Toshi