Re: [PATCH] drivers: staging: lustre: lustre: llite: file.c - fixed sparse warning about different fmode_t type

From: Greg Kroah-Hartman
Date: Fri Apr 28 2017 - 03:30:52 EST


On Mon, Apr 24, 2017 at 07:53:11AM +0100, Andrea della Porta wrote:
> fixed a couple of sparse warning complaining about type mismatch.

That's really vague, please be specific.

>
> Signed-off-by: Andrea della Porta <sfaragnaus@xxxxxxxxx>
> ---
> drivers/staging/lustre/lustre/include/lustre_intent.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre_intent.h b/drivers/staging/lustre/lustre/include/lustre_intent.h
> index ed2b6c6..c036633 100644
> --- a/drivers/staging/lustre/lustre/include/lustre_intent.h
> +++ b/drivers/staging/lustre/lustre/include/lustre_intent.h
> @@ -38,7 +38,7 @@
> struct lookup_intent {
> int it_op;
> int it_create_mode;
> - __u64 it_flags;
> + fmode_t it_flags;

Are you sure? Why? What exact warning did this "fix"?

thanks,

greg k-h