Re: [PATCH v2] ceph: Fix file open flags on ppc64

From: Alexander Graf
Date: Fri Apr 28 2017 - 05:17:12 EST




On 28.04.17 09:57, Yan, Zheng wrote:

On 28 Apr 2017, at 00:34, Alexander Graf <agraf@xxxxxxx> wrote:

The file open flags (O_foo) are platform specific and should never go
out to an interface that is not local to the system.

Unfortunately these flags have leaked out onto the wire in the cephfs
implementation. That lead to bogus flags getting transmitted on ppc64.

This patch converts the kernel view of flags to the ceph view of file
open flags.

Fixes: 124e68e74 ("ceph: file operations")
Signed-off-by: Alexander Graf <agraf@xxxxxxx>

â

I removed the "unused open flagsâ dout and applied the patch. Thank you for tracking down and fixing the bug.

I actually put that in on purpose, in case anyone in 2 years tries to find out why a particular flag doesn't get populated :).


Alex