Re: [PATCH v4] Input: psxpad-spi - Add PSX (Play Station 1/2) pad SPI driver

From: kbuild test robot
Date: Fri Apr 28 2017 - 14:29:52 EST


Hi Tomohiro,

[auto build test WARNING on input/next]
[also build test WARNING on v4.11-rc8 next-20170428]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Tomohiro-Yoshidomi/Input-psxpad-spi-Add-PSX-Play-Station-1-2-pad-SPI-driver/20170429-014135
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 6.2.0
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

drivers/input//joystick/psxpad-spi.c: In function 'psxpad_spi_probe':
>> drivers/input//joystick/psxpad-spi.c:496:5: warning: 'pdev' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (pdev) {
^

vim +/pdev +496 drivers/input//joystick/psxpad-spi.c

480 /* pad settings */
481 psxpad_setmotorlevel(pad, 0, 0);
482
483 /* register input pool device */
484 err = input_register_polled_device(pdev);
485 if (err) {
486 dev_err(&spi->dev, "psxpad-spi: probe: failed register!!\n");
487 input_free_polled_device(pdev);
488 goto err_free_mem;
489 }
490
491 pm_runtime_enable(&spi->dev);
492
493 return 0;
494
495 err_free_mem:
> 496 if (pdev) {
497 psxpad_spi_deinit_ff(pad);
498 input_free_polled_device(pdev);
499 }
500 devm_kfree(&spi->dev, pad);
501
502 return err;
503 }
504

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip