Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD

[Dmitry Torokhov]

On Fri, Apr 28, 2017 at 02:00:19PM -0700, Darren Hart (VMware) wrote:
> SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> driver. Make this explicitly clear in the Kconfig depends.
> 
> Signed-off-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxxxxx>
> Cc: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
>  drivers/platform/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9e5b2c2..5690664 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
>  
>  config SILEAD_DMI
>  	bool "Tablets with Silead touchscreens"
> -	depends on ACPI && DMI && I2C=y && INPUT
> +	depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD

Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop
INPUT dependency.

Otherwise

Reviewed-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

-- 
Dmitry