Re: [PATCH v4] platform/x86: ideapad-laptop: Add sysfs interface for touchpad state

[Andy Shevchenko]

On Sat, Apr 29, 2017 at 9:52 AM, Ritesh Raj Sarraf <rrs@xxxxxxxxxx> wrote:
> Hello,
>
> On Fri, 2017-04-28 at 22:17 +0300, Andy Shevchenko wrote:
>> On Wed, Feb 22, 2017 at 12:24 PM, Ritesh Raj Sarraf <rrs@xxxxxxxxxx> wrote:
>>
>> > Any further comment on this patch ? Will this be accepted ?
>> > Please give a N/ACK.
>>
>> Sorry for a long delay, but I can't go with this without clear
>> understanding that there is indeed no other ways available.
>> From what I read in the above link
>
> i am assuming you are referring to the launchpad bug report here.

Correct.

>> the main issue that driver doesn't
>> send SW_TABLET_MODE event through input device.
>
> Well. Yes. That is one part. If SW_TABLET_MODE is done in the driver, much
> better. My patch was simply in line with some of the other drivers (hp-wmi and
> thinkpad_acpi) to get it working for Lenovo Yoga series.

sysfs ABI for drivers that provide input interface is quite strong for
my opinion. It means I'm not totally objecting, but I would accept it
if and only if there is nothing else could be done.

-- 
With Best Regards,
Andy Shevchenko