Re: [PATCH v1] selftests: Make test_harness.h more generally available

[Will Drewry]

On Sun, Apr 30, 2017 at 12:39 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> On Sun, Apr 30, 2017 at 5:26 AM, MickaÃl SalaÃn <mic@xxxxxxxxxxx> wrote:
> > The seccomp/test_harness.h file contains useful helpers to build tests.
> > Moving it to the selftest directory should benefit to other test
> > components.
>
> Unless Shuah thinks this should live in a new include/ directory, this
> looks fine to me.
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

Same here!

Acked-by: Will Drewry <wad@xxxxxxxxxxxx>

>
> Thanks!
>
> -Kees
>
> >
> > Signed-off-by: MickaÃl SalaÃn <mic@xxxxxxxxxxx>
> > Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> > Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> > Cc: Shuah Khan <shuah@xxxxxxxxxx>
> > Cc: Will Drewry <wad@xxxxxxxxxxxx>
> > Link: https://lkml.kernel.org/r/CAGXu5j+8CVz8vL51DRYXqOY=xc3zuKFf=PTENe88XYHzFYidUQ@xxxxxxxxxxxxxx
> > ---
> >  tools/testing/selftests/seccomp/seccomp_bpf.c        | 2 +-
> >  tools/testing/selftests/{seccomp => }/test_harness.h | 0
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename tools/testing/selftests/{seccomp => }/test_harness.h (100%)
> >
> > diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
> > index 03f1fa495d74..d7095ff58e72 100644
> > --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
> > +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
> > @@ -37,7 +37,7 @@
> >  #include <unistd.h>
> >  #include <sys/syscall.h>
> >
> > -#include "test_harness.h"
> > +#include "../test_harness.h"
> >
> >  #ifndef PR_SET_PTRACER
> >  # define PR_SET_PTRACER 0x59616d61
> > diff --git a/tools/testing/selftests/seccomp/test_harness.h b/tools/testing/selftests/test_harness.h
> > similarity index 100%
> > rename from tools/testing/selftests/seccomp/test_harness.h
> > rename to tools/testing/selftests/test_harness.h
> > --
> > 2.11.0
> >
>
>
>
> --
> Kees Cook
> Pixel Security