Re: [PATCH v2 2/4] iio: accel: adxl345_core: Introduce set_mode and data_ready functions

[Jonathan Cameron]

On 1 May 2017 20:42:08 BST, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
>On Mon, May 1, 2017 at 3:22 AM, Jonathan Cameron <jic23@xxxxxxxxxx>
>wrote:
>> On 29/04/17 08:48, Eva Rachel Retuya wrote:
>
>>> +static int adxl345_set_mode(struct adxl345_data *data, u8 mode)
>>> +{
>>> +     struct device *dev = regmap_get_device(data->regmap);
>>> +     int ret;
>>> +
>>> +     ret = regmap_write(data->regmap, ADXL345_REG_POWER_CTL, mode);
>>> +     if (ret < 0) {
>>> +             dev_err(dev, "Failed to set power mode, %d\n", ret);
>>> +             return ret;
>> drop the return ret here and just return ret at the end of the
>function.
>> One of the static checkers will probably moan about this otherwise.
>
>But this will be not equivalent!
Why? Regmap_write returns 0 for success.
>
>>> +     }
>>> +
>>> +     return 0;
>>> +}

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.