Re: [PATCH 2/2] efi/efi_test: drop useless kfree

[ivanhu]

On 04/29/2017 09:42 AM, Geliang Tang wrote:
> Drop useless kfree when memdup_user() failed, since we have already
> called kfree in memdup_user().
>
> Signed-off-by: Geliang Tang <geliangtang@xxxxxxxxx>
> ---
>   drivers/firmware/efi/test/efi_test.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c
> index 08129b7..00332ae 100644
> --- a/drivers/firmware/efi/test/efi_test.c
> +++ b/drivers/firmware/efi/test/efi_test.c
> @@ -261,10 +261,8 @@ static long efi_runtime_set_variable(unsigned long arg)
>   	}
>   
>   	data = memdup_user(setvariable.data, setvariable.data_size);
> -	if (IS_ERR(data)) {
> -		kfree(name);
You mean "name" or "data"?

Cheers,
Ivan

> +	if (IS_ERR(data))
>   		return PTR_ERR(data);
> -	}
>   
>   	status = efi.set_variable(name, &vendor_guid,
>   				setvariable.attributes,