Re: [PATCH 2/4] PCI: add functionality for resizing resources v3

[Andy Shevchenko]

On Tue, May 2, 2017 at 6:51 PM, Christian KÃnig <deathsimple@xxxxxxxxxxx> wrote:
> Am 26.04.2017 um 19:00 schrieb Andy Shevchenko:
>> On Tue, Apr 25, 2017 at 4:19 PM, Christian KÃnig
>> <deathsimple@xxxxxxxxxxx> wrote:

>>> +int pci_reassign_bridge_resources(struct pci_dev *bridge, unsigned long
>>> type)
>>> +{
>>> +       const unsigned long type_mask = IORESOURCE_IO | IORESOURCE_MEM |
>>> +               IORESOURCE_PREFETCH | IORESOURCE_MEM_64;
>>> +
>>
>> Redundant.
>
>
> Redundant, but also a reminder to myself that I wanted to ask something
> about that.

Missed context I suppose. Usually I comment in one word something
obvious, i.e. redundant empty line.
Sorry for missing my point.

> This type_mask is used already three times in this file, shouldn't we add a
> define for that?

Yes, that's wxactly what I commented somewhere (in one of the rest cases).

-- 
With Best Regards,
Andy Shevchenko