Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

From: Geert Uytterhoeven
Date: Wed May 03 2017 - 08:48:07 EST

Hi Arnd,

On Wed, May 3, 2017 at 2:32 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Wed, May 3, 2017 at 2:18 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>> If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the
>> build will fail with:
>> net/built-in.o: In function `nf_conntrack_init_start':
>> (.text+0x9baf6): undefined reference to `__compiletime_assert_1893'
>> or
>> ERROR: "__compiletime_assert_1893" [net/netfilter/nf_conntrack.ko] undefined!
>> Fix this by forcing inlining of total_extension_size().
>> Fixes: b3a5db109e0670d6 ("netfilter: conntrack: use u8 for extension sizes again")
>> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> I saw this as well when I tried building with "gcc-7 -Og", and came to the same
> conclusion.

Good^H^H^H^HBad to see it not only happens with ancient compilers ;-)

> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>




Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds