RE: [PATCH] staging: unisys: Solve sparse warning

[Kershner, David A]

> -----Original Message-----
> From: Marcos Paulo de Souza [mailto:marcos.souza.org@xxxxxxxxx]
> Sent: Tuesday, May 2, 2017 11:28 PM
> Cc: Marcos Paulo de Souza <marcos.souza.org@xxxxxxxxx>; Kershner, David
> A <David.Kershner@xxxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Sell, Timothy C <Timothy.Sell@xxxxxxxxxx>;
> Binder, David Anthony <David.Binder@xxxxxxxxxx>; Erik Arfvidson
> <erik.arfvidson@xxxxxxxxxx>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@xxxxxxxxxx>; Curtin, Alexander Paul
> <Alexander.Curtin@xxxxxxxxxx>; *S-Par-Maintainer
> <SParMaintainer@xxxxxxxxxx>; devel@xxxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] staging: unisys: Solve sparse warning
> 
> The following commit fixes the following sparse report:
> 
> drivers/staging//unisys/visorhba/visorhba_main.c:660:29: warning: cast to
> restricted __le64
> 
> by casting readq (which is unsigned long on x86) to u64, as expected by the
> seq_printf call.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@xxxxxxxxx>
> ---
>  Just compiled tested on x86_64.
> 
>  drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 6997b16..46d33e6 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -657,7 +657,7 @@ static int info_debugfs_show(struct seq_file *seq,
> void *v)
>  		seq_printf(seq, "phys_flags_addr = 0x%016llx\n",
>  			   phys_flags_addr);
>  		seq_printf(seq, "FeatureFlags = %llu\n",
> -			   (__le64)readq(devdata->flags_addr));
> +			   (u64)readq(devdata->flags_addr));

Acked-by: David Kershner <david.kershner@xxxxxxxxxx>

>  	}
>  	seq_printf(seq, "acquire_failed_cnt = %llu\n",
>  		   devdata->acquire_failed_cnt);
> --
> 2.9.3