Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed
From: Dmitry Monakhov
Date: Wed May 03 2017 - 12:07:45 EST
"Martin K. Petersen" <martin.petersen@xxxxxxxxxx> writes:
> Dmitry Monakhov <dmonakhov@xxxxxxxxxx> writes:
>> SCSI drivers do care about bip_seed so we must update it accordingly.
>> + bip->bip_iter.bi_sector += bytes_done >> 9;
> This needs to count protection intervals. Otherwise things will break
> for block sizes different from 512 bytes.
AFAIU: bip->bip_iter.bi_sector is always equals to bio->bi_iter.bi_sector
at least bip_set_seed() and bip_get_seed() relays on that.
Only bip->bip_vec must be advanced in intervals (this behavior not
changed by the patch this patch).
> Martin K. Petersen Oracle Linux Engineering