Re: [PATCH] power: supply: bq27xxx: make bq27xxx_battery_settings static

[Pali RohÃr]

On Wednesday 03 May 2017 11:45:54 Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The function bq27xxx_battery_settings can be made static as it
> does not need to be in global scope.
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/power/supply/bq27xxx_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 7152370b9d61..06f15da32464 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1251,7 +1251,7 @@ static void bq27xxx_battery_set_config(struct bq27xxx_device_info *di,
>  	/* assume bq27xxx_battery_update() is called hereafter */
>  }
>  
> -void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
> +static void bq27xxx_battery_settings(struct bq27xxx_device_info *di)
>  {
>  	struct power_supply_battery_info info = {};
>  	unsigned int min, max;

Reviewed-by: Pali RohÃr <pali.rohar@xxxxxxxxx>

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx