Re: [PATCH 2/3] nVMX: Implement emulated Page Modification Logging

[Paolo Bonzini]

On 04/05/2017 00:14, Bandan Das wrote:
> +	if (vmx->nested.pml_full) {
> +		exit_reason = EXIT_REASON_PML_FULL;
> +		vmx->nested.pml_full = false;
> +	} else if (fault->error_code & PFERR_RSVD_MASK)
>  		exit_reason = EXIT_REASON_EPT_MISCONFIG;
>  	else
>  		exit_reason = EXIT_REASON_EPT_VIOLATION;
> +	/*
> +	 * The definition of bit 12 for EPT violations and PML
> +	 * full event is the same, so pass it through since
> +	 * the rest of the bits are undefined.
> +	 */

Please zero all other bits instead.  It's as easy as adding an "u64
exit_qualification" local variable.

Paolo

>  	nested_vmx_vmexit(vcpu, exit_reason, 0, vcpu->arch.exit_qualification);