Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser

[Arnaldo Carvalho de Melo]

Em Thu, May 04, 2017 at 11:01:48AM +0200, Milian Wolff escreveu:
> On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote:
> > This patch adds the titles "Percent", "IPC" and "Cycle"
> > on columns.

> > Percnt   IPC Cycle â
> >                    â25  __attribute__((noinline))
> >                    â26  int compute_flag()
> >                    â27  {
> >  22.80  1.20       â      sub    $0x8,%rsp
> >                    â25          int i;
> >                    â
> >                    â27          i = rand() % 2;
> >  22.78  1.20     1 â    â callq  rand@plt

> > The titles are displayed at row 0 of annotate browser if row 0
> > doesn't have values of percent, ipc and cycle.
 
> Functionality wise a really good improvement - thanks! But personally I find 
> the abbreviation of one character (i.e. "Percnt" instead of "Percent") not so 
> nice. If space really is an issue here, use "%"?

Ok, will make it 'Percent' as we have space for that, and will add
Acked-by: Millian, ok?
 
> Also note though that it's unclear what this percentage actually is. I guess 
> it's a sample percentage? Maybe a header should be added that explains these 
> values to newbies. I bet many people won't even know what IPC is either.

Perhaps we could have some help files, then when the user presses 'h'
one of the lines would be:

  h   Report explanation (columns, etc)

?

- Arnaldo