Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver

From: Maxime Ripard
Date: Thu May 04 2017 - 10:06:55 EST


On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote:
> Allwinner A10, A20 and R40 SoCs have similar GPIO layout.
>
> Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support
> into A10 driver, and add R40 support into it.

While your commit log is good, the commit title is misleading since
you're not adding it to the A10 driver. You just adding SoC IDs
definitions

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature