Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

[BjÃrn Mork]

Jim Baxter <jim_baxter@xxxxxxxxxx> writes:

> The zero padding that is added to NTB's does
> not zero the memory correctly.
> This is because the skb_put modifies the value
> of skb_out->len which results in the memset
> command not setting any memory to zero as
> (ctx->tx_max - skb_out->len) == 0.
>
> I have resolved this by storing the size of
> the memory to be zeroed before the skb_put
> and using this in the memset call.
>
> Signed-off-by: Jim Baxter <jim_baxter@xxxxxxxxxx>

Ouch! Thanks for finding this.  This should go to the stable queue as
well.

Reviewed-by: BjÃrn Mork <bjorn@xxxxxxx>