Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules

From: Geert Uytterhoeven
Date: Fri May 05 2017 - 07:08:55 EST

On Fri, May 5, 2017 at 12:13 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Fri, May 5, 2017 at 12:07 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>> On Fri, May 05, 2017 at 11:49:11AM +0200, Geert Uytterhoeven wrote:
>>> When using signal_wake_up() from a loadable kernel module:
>>> ERROR: "signal_wake_up_state" [drivers/spi/spi-sh-msiof.ko] undefined!
>>> Export signal_wake_up_state() to modules to fix this.
>> Or rever the commit that added the users. This doesn't look like
> That commit is not yet applied.
>> functionality a driver should use..
> OK.
> Then, do you have any advise on how to properly abort a completion?

Of course I can add a flag to indicate abortion, and just call complete_all(),
but IMHO that's a bit silly, given wait_for_completion_interruptible() already
provides this side channel information through -ERESTARTSYS.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds