Re: [PATCH] Fixed a pathing issue with objdump and grep
From: Ravi Bangoria
Date: Fri May 05 2017 - 09:31:06 EST
On Friday 05 May 2017 06:52 PM, Ravi Bangoria wrote:
> On Friday 05 May 2017 06:27 PM, Arnaldo Carvalho de Melo wrote:
>> Em Wed, May 03, 2017 at 12:12:23PM +0000, Adam Stylinski escreveu:
>>> The path fed to the argument for objdump used in the perf-annotate
>>> feature didn't escape spaces. The subsequent argument to grep for
>>> the name of the DSO containing symbols also assumed no spaces existed
>>> in the pathname, so grep also parsed these as extra positional
>> This one didn't apply to tip/perf/urgent, so I tried another patch
>> addressing the same issue, from Ravi Bangoria, and it applied, ok?
> Oh, I was not aware about this patch. Coincidently, I sent the same fix. :)
BTW, Adam, Looks like you have older code. The same line was recently
changed by Taeung Song in commit e7cb9de211ebb29. I don't see that
change in your code.