Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling

From: Greg KH
Date: Fri May 05 2017 - 15:59:11 EST

On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
> This patch fixes several issues:
> - if the 1st 'kzalloc' fails, we dereference a NULL pointer
> - if the 2nd 'kzalloc' fails, there is a memory leak
> - if 'sysfs_create_bin_file' fails there is also a memory leak

Then it should be multiple patches, not fixing 3 things in one patch,


greg k-h