Re: [PATCH v3 2/4] dt-binding: meson_uart: add documentation for the UARTs of amlogic
From: Martin Blumenstingl
Date: Fri May 05 2017 - 17:43:31 EST
On Fri, Mar 31, 2017 at 6:54 PM, Helmut Klein <hgkr.klein@xxxxxxxxx> wrote:
> Add the documentation for the device tree binding of meson_uart
> Signed-off-by: Helmut Klein <hgkr.klein@xxxxxxxxx>
> .../bindings/serial/amlogic,meson_uart.txt | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt
> diff --git a/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt
> new file mode 100644
> index 000000000000..8250a191c2fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/amlogic,meson_uart.txt
> @@ -0,0 +1,30 @@
> +* Amlogic Meson UART, used in multiple SoCs (e.g. S905, s905X, ...)
> +Required properties:
> +- compatible : "amlogic,meson-uart"
> +- reg : offset and length of the register set for the device.
> +- interrupts : device interrupt
> +- clocks : a list of phandle + clock-specifier pairs, one for each
> + entry in clock names.
> +- clocks-names : contains:
> + * "xtal" for the baud rate clock
> + * "core" for the core clock of none AO UARTs (optional)
I'm not sure if we should name the first clock "xtal" as on Meson8b
clk81 is used as input, see .
maybe "refclk" or "clkin" (the latter is already used in other meson
drivers, see sd_emmc_*, saradc, ethmac, and so on)
apart from that the whole series is a good thing (if the other small
nits - for example from Rob - are fixed)!