Re: [PATCH 7/7] DWARF: add the config option
From: Ingo Molnar
Date: Sat May 06 2017 - 03:20:10 EST
* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, May 5, 2017 at 5:22 AM, Jiri Slaby <jslaby@xxxxxxx> wrote:
> > The DWARF unwinder is in place and ready. So introduce the config option
> > to allow users to enable it. It is by default off due to missing
> > assembly annotations.
> Who actually ends up using this?
Also, why wasn't Josh Poimboeuf Cc:-ed, who de-facto maintains the x86 unwinding
AFAICS this series is just repeating the old mistakes of the old Dwarf unwinders
of trusting GCC's unwinder data. So NAK for the time being on the whole approach:
NAcked-by: Ingo Molnar <mingo@xxxxxxxxxx>