Re: [PATCH] firmware: Google VPD: Fix memory allocation error handling

From: Dan Carpenter
Date: Sat May 06 2017 - 04:40:42 EST

On Fri, May 05, 2017 at 12:56:47PM -0700, Greg KH wrote:
> On Fri, May 05, 2017 at 09:08:44PM +0200, Christophe JAILLET wrote:
> > This patch fixes several issues:
> > - if the 1st 'kzalloc' fails, we dereference a NULL pointer
> > - if the 2nd 'kzalloc' fails, there is a memory leak
> > - if 'sysfs_create_bin_file' fails there is also a memory leak
> Then it should be multiple patches, not fixing 3 things in one patch,
> right?

I agree with Christophe that this is basically one thing. Otherwise you
end up breaking it up how Elfring does it into tiny tiny snippets that I
can't read. Doing it this way is easier to review for me.

dan carpenter