Re: [PATCH 3/3] staging: rtl8723bs: fix up for cfg80211_roamed() API change

From: kbuild test robot
Date: Sat May 06 2017 - 16:34:47 EST

Next message: Greg Kroah-Hartman: "[PATCH 4.10 0/5] 4.10.15-stable review"
Previous message: kbuild test robot: "Re: [PATCH 2/3] staging: rtl8723bs: merge fix for "nl80211: allow multiple active scheduled scan requests""
In reply to: Greg KH: "[PATCH 3/3] staging: rtl8723bs: fix up for cfg80211_roamed() API change"
Next in thread: kbuild test robot: "Re: [PATCH 2/3] staging: rtl8723bs: merge fix for "nl80211: allow multiple active scheduled scan requests""
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Stephen,

[auto build test ERROR on staging/staging-testing]
[cannot apply to v4.11 next-20170505]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Greg-KH/staging-rtl8723bs-merge-fix-for-add-change_virtual-intf-API-change/20170507-034455
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=alpha

All error/warnings (new ones prefixed by >>):

drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c: In function 'rtw_cfg80211_indicate_connect':
>> drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:545:10: error: variable 'roam_info' has initializer but incomplete type
struct cfg80211_roam_info roam_info = {};
^~~~~~~~~~~~~~~~~~
>> drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:545:29: error: storage size of 'roam_info' isn't known
struct cfg80211_roam_info roam_info = {};
^~~~~~~~~
In file included from include/linux/slab.h:14:0,
from drivers/staging//rtl8723bs/include/osdep_service_linux.h:23,
from drivers/staging//rtl8723bs/include/osdep_service.h:23,
from drivers/staging//rtl8723bs/include/drv_types.h:29,
from drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:17:
>> include/linux/gfp.h:239:20: warning: passing argument 3 of 'cfg80211_roamed' makes pointer from integer without a cast [-Wint-conversion]
#define GFP_ATOMIC (__GFP_HIGH|__GFP_ATOMIC|__GFP_KSWAPD_RECLAIM)
^
>> drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:562:50: note: in expansion of macro 'GFP_ATOMIC'
cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC);
^~~~~~~~~~
In file included from drivers/staging//rtl8723bs/include/osdep_service_linux.h:50:0,
from drivers/staging//rtl8723bs/include/osdep_service.h:23,
from drivers/staging//rtl8723bs/include/drv_types.h:29,
from drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:17:
include/net/cfg80211.h:5233:6: note: expected 'const u8 * {aka const unsigned char *}' but argument is of type 'unsigned int'
void cfg80211_roamed(struct net_device *dev,
^~~~~~~~~~~~~~~
>> drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:562:3: error: too few arguments to function 'cfg80211_roamed'
cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC);
^~~~~~~~~~~~~~~
In file included from drivers/staging//rtl8723bs/include/osdep_service_linux.h:50:0,
from drivers/staging//rtl8723bs/include/osdep_service.h:23,
from drivers/staging//rtl8723bs/include/drv_types.h:29,
from drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:17:
include/net/cfg80211.h:5233:6: note: declared here
void cfg80211_roamed(struct net_device *dev,
^~~~~~~~~~~~~~~
drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:545:29: warning: unused variable 'roam_info' [-Wunused-variable]
struct cfg80211_roam_info roam_info = {};
^~~~~~~~~
drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c: At top level:
drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:3430:25: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.change_virtual_intf = cfg80211_rtw_change_iface,
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:3430:25: note: (near initialization for 'rtw_cfg80211_ops.change_virtual_intf')
drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:3449:22: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.add_virtual_intf = cfg80211_rtw_add_virtual_intf,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c:3449:22: note: (near initialization for 'rtw_cfg80211_ops.add_virtual_intf')
cc1: some warnings being treated as errors
--
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: In function 'rtw_cfg80211_indicate_connect':
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:545:10: error: variable 'roam_info' has initializer but incomplete type
struct cfg80211_roam_info roam_info = {};
^~~~~~~~~~~~~~~~~~
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:545:29: error: storage size of 'roam_info' isn't known
struct cfg80211_roam_info roam_info = {};
^~~~~~~~~
In file included from include/linux/slab.h:14:0,
from drivers/staging/rtl8723bs/include/osdep_service_linux.h:23,
from drivers/staging/rtl8723bs/include/osdep_service.h:23,
from drivers/staging/rtl8723bs/include/drv_types.h:29,
from drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:17:
>> include/linux/gfp.h:239:20: warning: passing argument 3 of 'cfg80211_roamed' makes pointer from integer without a cast [-Wint-conversion]
#define GFP_ATOMIC (__GFP_HIGH|__GFP_ATOMIC|__GFP_KSWAPD_RECLAIM)
^
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:562:50: note: in expansion of macro 'GFP_ATOMIC'
cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC);
^~~~~~~~~~
In file included from drivers/staging/rtl8723bs/include/osdep_service_linux.h:50:0,
from drivers/staging/rtl8723bs/include/osdep_service.h:23,
from drivers/staging/rtl8723bs/include/drv_types.h:29,
from drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:17:
include/net/cfg80211.h:5233:6: note: expected 'const u8 * {aka const unsigned char *}' but argument is of type 'unsigned int'
void cfg80211_roamed(struct net_device *dev,
^~~~~~~~~~~~~~~
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:562:3: error: too few arguments to function 'cfg80211_roamed'
cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC);
^~~~~~~~~~~~~~~
In file included from drivers/staging/rtl8723bs/include/osdep_service_linux.h:50:0,
from drivers/staging/rtl8723bs/include/osdep_service.h:23,
from drivers/staging/rtl8723bs/include/drv_types.h:29,
from drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:17:
include/net/cfg80211.h:5233:6: note: declared here
void cfg80211_roamed(struct net_device *dev,
^~~~~~~~~~~~~~~
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:545:29: warning: unused variable 'roam_info' [-Wunused-variable]
struct cfg80211_roam_info roam_info = {};
^~~~~~~~~
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c: At top level:
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3430:25: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.change_virtual_intf = cfg80211_rtw_change_iface,
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3430:25: note: (near initialization for 'rtw_cfg80211_ops.change_virtual_intf')
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3449:22: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.add_virtual_intf = cfg80211_rtw_add_virtual_intf,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:3449:22: note: (near initialization for 'rtw_cfg80211_ops.add_virtual_intf')
cc1: some warnings being treated as errors

vim +/roam_info +545 drivers/staging//rtl8723bs/os_dep/ioctl_cfg80211.c

539
540 if (rtw_to_roam(padapter) > 0) {
541 struct wiphy *wiphy = pwdev->wiphy;
542 struct ieee80211_channel *notify_channel;
543 u32 freq;
544 u16 channel = cur_network->network.Configuration.DSConfig;
> 545 struct cfg80211_roam_info roam_info = {};
546
547 freq = rtw_ieee80211_channel_to_frequency(channel, NL80211_BAND_2GHZ);
548
549 notify_channel = ieee80211_get_channel(wiphy, freq);
550
551 DBG_871X(FUNC_ADPT_FMT" call cfg80211_roamed\n", FUNC_ADPT_ARG(padapter));
552 roam_info.channel = notify_channel;
553 roam_info.bssid = cur_network->network.MacAddress;
554 roam_info.req_ie =
555 pmlmepriv->assoc_req+sizeof(struct ieee80211_hdr_3addr)+2;
556 roam_info.req_ie_len =
557 pmlmepriv->assoc_req_len-sizeof(struct ieee80211_hdr_3addr)-2;
558 roam_info.resp_ie =
559 pmlmepriv->assoc_rsp+sizeof(struct ieee80211_hdr_3addr)+6;
560 roam_info.resp_ie_len =
561 pmlmepriv->assoc_rsp_len-sizeof(struct ieee80211_hdr_3addr)-6;
> 562 cfg80211_roamed(padapter->pnetdev, &roam_info, GFP_ATOMIC);
563 }
564 else
565 {

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip

Next message: Greg Kroah-Hartman: "[PATCH 4.10 0/5] 4.10.15-stable review"
Previous message: kbuild test robot: "Re: [PATCH 2/3] staging: rtl8723bs: merge fix for "nl80211: allow multiple active scheduled scan requests""
In reply to: Greg KH: "[PATCH 3/3] staging: rtl8723bs: fix up for cfg80211_roamed() API change"
Next in thread: kbuild test robot: "Re: [PATCH 2/3] staging: rtl8723bs: merge fix for "nl80211: allow multiple active scheduled scan requests""
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]