Re: [PATCH] char: random: casting prevents missing calculations

From: Arnd Bergmann
Date: Sun May 07 2017 - 17:42:09 EST


On Sun, May 7, 2017 at 2:47 PM, Karim Eshapa <karim.eshapa@xxxxxxxxx> wrote:
> Cast (long)jiffies and (long)state->last_time beacause
> they tends to unsigned long. may cause a problem specially
> when comparison happens (< 0).
>
> Signed-off-by: Karim Eshapa <karim.eshapa@xxxxxxxxx>

I don't understand what you are saying above, and the patch does not
appear to have any effect since the destination variable is already of
type 'long'.

What problem did you observe?

Arnd