Re: [PATCH] perf, tools: Support srccode output

From: Andi Kleen
Date: Sun May 07 2017 - 18:03:10 EST


> so get_srcline formats srcline and you parse it out back in here,
> I think it'd be better to factor __get_srcline and get the file
> and line directly

It's not true for the addr2line fallback which gets the already formatted
string. So at some point it would need to be parsed.

But ok I can move it into the low level function. It just makes the patch
more complicated.

-Andi