Re: [PATCH 2/2] staging: ccree: Fix initialization of anonymous unions

[Arnd Bergmann]

On Sun, May 7, 2017 at 9:53 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> With gcc 4.1.2:
>
>     drivers/staging/ccree/ssi_hash.c:1990: error: unknown field âtemplate_ahashâ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1991: error: unknown field âinitâ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1991: warning: missing braces around initializer
>     drivers/staging/ccree/ssi_hash.c:1991: warning: (near initialization for âdriver_hash[0].<anonymous>.template_ahashâ)
>     drivers/staging/ccree/ssi_hash.c:1992: error: unknown field âupdateâ specified in initializer
>     drivers/staging/ccree/ssi_hash.c:1992: warning: excess elements in union initializer
>     ...
>
> Add missing braces to fix this.
> After this it compiles without warnings with gcc 4.1.2 and 4.9.0.

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

For reference, we need this up to gcc-4.5, the anonymous initializers were added
on gcc-4.6.

     Arnd