Re: [RFC][PATCH 0/9] VFS: Introduce mount context

From: David Howells
Date: Mon May 08 2017 - 04:36:12 EST


David Howells <dhowells@xxxxxxxxxx> wrote:

> > This patchset achieves this partly, but the separation is far from
> > crisp clear... First of all why is fsopen() creating a "mount
> > context"? It's suppsed to create a "superblock creation context".
>
> I've no particular objection to renaming struct mount_context to something
> else, but it also needs to handle remount because of the commonality.
>
> Further, once you've created a superblock, what are you going to do with it
> other than mount it? I suppose you could statfs it and we could add other
> superblock manipulation functions, but this is normally done by opening the
> device directly (at least for bdev-based superblocks).

How about sb_context, sb_config, sb_parameters or something like that?

David