Re: [PATCH v5 15/32] efi: Update efi_mem_type() to return an error rather than 0

[Tom Lendacky]

On 5/7/2017 12:18 PM, Borislav Petkov wrote:
> On Tue, Apr 18, 2017 at 04:19:00PM -0500, Tom Lendacky wrote:
> > The efi_mem_type() function currently returns a 0, which maps to
> > EFI_RESERVED_TYPE, if the function is unable to find a memmap entry for
> > the supplied physical address. Returning EFI_RESERVED_TYPE implies that
> > a memmap entry exists, when it doesn't.  Instead of returning 0, change
> > the function to return a negative error value when no memmap entry is
> > found.
> >
> > Signed-off-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
> > ---
>
> ...
>
> > diff --git a/include/linux/efi.h b/include/linux/efi.h
> > index cd768a1..a27bb3f 100644
> > --- a/include/linux/efi.h
> > +++ b/include/linux/efi.h
> > @@ -973,7 +973,7 @@ static inline void efi_esrt_init(void) { }
> >  extern int efi_config_parse_tables(void *config_tables, int count, int sz,
> >  				   efi_config_table_type_t *arch_tables);
> >  extern u64 efi_get_iobase (void);
> > -extern u32 efi_mem_type (unsigned long phys_addr);
> > +extern int efi_mem_type (unsigned long phys_addr);
>
> WARNING: space prohibited between function name and open parenthesis '('
> #101: FILE: include/linux/efi.h:976:
> +extern int efi_mem_type (unsigned long phys_addr);
>
> Please integrate scripts/checkpatch.pl in your patch creation workflow.
> Some of the warnings/errors *actually* make sense.

I do/did run scripts/checkpatch.pl against all my patches. In this case
I chose to keep the space in order to stay consistent with some of the
surrounding functions.  No problem though, I can remove the space.

Thanks,
Tom

> I know, the other function prototypes have a space too but that's not
> our coding style. Looks like this trickled in from ia64, from looking at
> arch/ia64/kernel/efi.c.