Re: [PATCH V2 1/1] net: cdc_ncm: Fix TX zero padding

From: David Miller
Date: Mon May 08 2017 - 16:02:00 EST


From: Jim Baxter <jim_baxter@xxxxxxxxxx>
Date: Mon, 8 May 2017 13:49:57 +0100

> The zero padding that is added to NTB's does
> not zero the memory correctly.
> This is because the skb_put modifies the value
> of skb_out->len which results in the memset
> command not setting any memory to zero as
> (ctx->tx_max - skb_out->len) == 0.
>
> I have resolved this by storing the size of
> the memory to be zeroed before the skb_put
> and using this in the memset call.
>
> Signed-off-by: Jim Baxter <jim_baxter@xxxxxxxxxx>
> Reviewed-by: Bjørn Mork <bjorn@xxxxxxx>

Applied, thank you.