Re: [PATCH] sched/fair: WARN and refuse to set buddy when !se->on_rq

From: Peter Zijlstra
Date: Tue May 09 2017 - 02:45:20 EST


On Mon, May 08, 2017 at 10:32:30PM +0300, Konstantin Khlebnikov wrote:
> On Mon, May 8, 2017 at 10:22 PM, Daniel Axtens <dja@xxxxxxxxxx> wrote:

> > I recently had to debug a problem with these (we hadn't backported
> > Konstantin's patches in this area) and this would have saved a lot
> > of time/pain.
>
> Yep, this is worth debug. But I think it should be under compile-time
> config option.
> Something like CONFIG_DEBUG_VM which enables VM_BUG_ON and VM_WARN_ON.

See SCHED_WARN_ON() and feel free to introduce SCHED_WARN_ON_ONCE() if
you feel that's needed.