Re: [PATCH] staging: typec: Make undeclared symbol static

From: Guenter Roeck
Date: Tue May 09 2017 - 12:05:02 EST


On Tue, May 09, 2017 at 01:48:53AM -0700, Guru Das Srinagesh wrote:
> Fix sparse warning:
> drivers/staging/typec/tcpci.c:428:26: warning: symbol 'tcpci_tcpc_config'
> was not declared. Should it be static?
>
> Signed-off-by: Guru Das Srinagesh <gurooodas@xxxxxxxxx>

Olivier Leveque already sent a similar patch last week.

Thanks,
Guenter

> ---
> drivers/staging/typec/tcpci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c
> index 5e5be74..df72d8b 100644
> --- a/drivers/staging/typec/tcpci.c
> +++ b/drivers/staging/typec/tcpci.c
> @@ -425,7 +425,7 @@ static const struct regmap_config tcpci_regmap_config = {
> .max_register = 0x7F, /* 0x80 .. 0xFF are vendor defined */
> };
>
> -const struct tcpc_config tcpci_tcpc_config = {
> +static const struct tcpc_config tcpci_tcpc_config = {
> .type = TYPEC_PORT_DFP,
> .default_role = TYPEC_SINK,
> };
> --
> 2.7.4
>