Re: linux-next: build warning after merge of the block tree
From: Stephen Rothwell
Date: Tue May 09 2017 - 23:26:15 EST
Hi Markus,
On Wed, 10 May 2017 04:20:54 +0200 Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx> wrote:
>
> Yes, it was missing a (void) like "(void)strlcpy(...)". But Jens
> unfortunately removed both warnings, so the following patch should now
> be enough:
>
> diff --git a/block/elevator.c b/block/elevator.c
> index fda6be933130..dd0ed19e4fb7 100644
> --- a/block/elevator.c
> +++ b/block/elevator.c
> @@ -1099,8 +1099,7 @@ ssize_t elv_iosched_store(struct request_queue *q, const char *name,
> return count;
>
> strlcpy(elevator_name, skip_spaces(name), sizeof(elevator_name));
> - strstrip(elevator_name);
> - ret = __elevator_change(q, elevator_name);
> + ret = __elevator_change(q, strstrip(elevator_name));
> if (!ret)
> return count;
I think you (or someone) needs to do a proper patch submission to Jens,
please.
--
Cheers,
Stephen Rothwell