Re: [linux-next][bock] [bisected c20cfc27a] WARNING: CPU: 22 PID: 0 at block/blk-core.c:2655 .blk_update_request+0x4f8/0x500

From: Christoph Hellwig
Date: Wed May 10 2017 - 03:56:49 EST


On Tue, May 09, 2017 at 08:48:21PM +0530, Abdul Haleem wrote:
> A bisection for the above suspects resulted a bad commit;
>
> c20cfc27a47307e811346f85959cf3cc07ae42f9 is the first bad commit
> commit c20cfc27a47307e811346f85959cf3cc07ae42f9
> Author: Christoph Hellwig <hch@xxxxxx>
> Date: Wed Apr 5 19:21:07 2017 +0200
>
> block: stop using blkdev_issue_write_same for zeroing

And this effectively switches us to use the write_zeroes for SCSI.



>
> We'll always use the WRITE ZEROES code for zeroing now.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
> Signed-off-by: Jens Axboe <axboe@xxxxxx>
>
>
> @Christoph FYI, the machine configured with 64K page size
> >
> > WARNING: CPU: 12 PID: 0 at block/blk-core.c:2651 .blk_update_request+0x4cc/0x4e0

Can you decode which warning this is? Is it:

WARN_ON_ONCE(req->rq_flags & RQF_SPECIAL_PAYLOAD);

? In which case your setup did a partial completion of a WRITE SAME
command, which is perfectly legal according to SCSI, but a bit unusual.