Re: [PATCH] mm/vmscan: fix unsequenced modification and access warning

From: Nick Desaulniers
Date: Wed May 10 2017 - 04:46:13 EST


> You can add

Something that's not clear to me when advised to add, should I be
uploading a v3 with your acked by? I think I got that wrong the last
time I asked (which was my first patch to Linux).

> But I still do not understand which part of the code is undefined and
> why.

It's not immediately clear to me either, but it's super later here...

> is this a bug in -Wunsequenced in Clang

Possibly, I think I already found one earlier tonight.

https://bugs.llvm.org/show_bug.cgi?id=32985

Tomorrow, I'll try to cut down a test case to see if this is indeed a
compiler bug. Would you like me to change the commit message to call
this just a simple clean up, in the meantime?

Thanks,
~Nick