Re: [PATCH v3 3/3] arm64: Silence first allocation with CONFIG_ARM64_MODULE_PLTS=y

From: Will Deacon
Date: Wed May 10 2017 - 07:55:11 EST


On Wed, May 10, 2017 at 09:38:03AM +0100, Catalin Marinas wrote:
> On Mon, May 08, 2017 at 11:07:24AM +0100, Will Deacon wrote:
> > On Fri, May 05, 2017 at 02:07:28PM -0700, Florian Fainelli wrote:
> > > On 05/03/2017 04:18 AM, Will Deacon wrote:
> > > > On Thu, Apr 27, 2017 at 11:19:02AM -0700, Florian Fainelli wrote:
> > > >> When CONFIG_ARM64_MODULE_PLTS is enabled, the first allocation using the
> > > >> module space fails, because the module is too big, and then the module
> > > >> allocation is attempted from vmalloc space. Silence the first allocation
> > > >> failure in that case by setting __GFP_NOWARN.
> > > >>
> > > >> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> > > >> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> > > >> ---
> > > >> arch/arm64/kernel/module.c | 7 ++++++-
> > > >> 1 file changed, 6 insertions(+), 1 deletion(-)
> > > >
> > > > I'm not sure what the merge plan is for these, but the arm64 bit here
> > > > looks fine to me:
> > > >
> > > > Acked-by: Will Deacon <will.deacon@xxxxxxx>
> > >
> > > Thanks, not sure either, would you or Catalin want to pick this series?
> >
> > We'd need an Ack from Russell on the arch/arm/ part before we could take
> > this series.
>
> The first patch touches mm/vmalloc.c, so we could also merge the series
> via akpm's tree. Andrew, do you have any preference?

Michal Hocko acked that one, so I think we can take the whole series via
arm64.

Will