Re: [PATCH v2 01/10] dmaengine: omap-dma: port_window support correction for both direction
From: Tony Lindgren
Date: Wed May 10 2017 - 12:28:57 EST
* Peter Ujfalusi <peter.ujfalusi@xxxxxx> [170510 01:45]:
> When the port_window support was verified it was done on setup where only
> the MEM_TO_DEV direction was enabled. This got un-noticed and thus only
> this direction worked.
>
> Now that I have managed to get a setup to verify both direction it turned
> out that the setup was incorrect:
> omap_desc members are settings for the slave port while the omap_sg members
> apply to the memory side of the sDMA setup.
>
> Fixes: 527a27591312 ("dmaengine: omap-dma: Fix the port_window support")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> Cc: dmaengine@xxxxxxxxxxxxxxx
> Cc: dan.j.williams@xxxxxxxxx
> Cc: vinod.koul@xxxxxxxxx
Tested-by: Tony Lindgren <tony@xxxxxxxxxxx>