Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

[Alan Cox]

> +	if (!(tmp_termios.c_cflag & CRTSCTS)) {
> +		tmp_termios.c_cflag |= CRTSCTS;
> +		ret = tty_set_termios(tty, &tmp_termios);
> +		if (ret)
> +			pr_warn("speakup: Failed to set hardware flow control\n");

You should check the tty c_cflag after the call rather than rely on an
error code. Strictly speaking tty_set_termios should error if no tty bits
are changed by the request but it never has on Linux. Instead check the
tty gave you the result you wanted.

Alan