Re: [PATCH] drbd: fix request leak introduced by locking/atomic, kref: Kill kref_sub()

From: Jens Axboe
Date: Thu May 11 2017 - 12:04:00 EST


On 05/11/2017 02:21 AM, Lars Ellenberg wrote:
> Regression fix for 4.11, which totally broke DRBD
>
> When killing kref_sub(), the unconditional additional kref_get()
> was not properly paired with the necessary kref_put(), causing
> a leak of struct drbd_requests (~ 224 Bytes) per submitted bio,
> and breaking DRBD in general, as the destructor of those "drbd_requests"
> does more than just the mempoll_free().

Ugh... Applied for this series. I'll mark it stable for 4.11.

--
Jens Axboe