Re: pinctrl-sx150x.c broken in 4.11

From: Nikita Yushchenko
Date: Thu May 11 2017 - 15:11:20 EST


>>> Maybe create_pinctrl() could check if the pin controller device
>>> for a potential hog points to the device itself and bail out
>>> if that's not the case?
>>
>> Well that's exactly what patch from my first mail in this thread does.
>> This indeed fixes my case, but I don't know if it is correct in generic
>> case.
>
> OK, yeah I just looked it up as I was not in cc.
>
>> Should I submit it? Do you ack?
>
> Yeah please submit a proper patch. I assume you already checked
> that this change only affects the pinctrl hogs only, not regular
> device pins? I'd assume so as it's in create_pinctrl()..

Regular device pins go via pinctrl_get() which calls create_pinctrl()
with second argument set to NULL.