Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

[Lino Sanfilippo]

Hi,

On 11.05.2017 20:29, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The error status err is initialized as zero and then being checked
> several times to see if it is less than zero even when it has not
> been updated.  It may seem that the err should be assigned to the
> return code of the call to the various *offload_en_set calls and
> then we check for failure, however, these functions are void and
> never actually return any status.  
> 
> Since these error checks are redundant we can remove these
> as well as err and the error exit label err_exit.
> 
> Detected by CoverityScan, CID#1398313 and CID#1398306 ("Logically
> dead code")
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

FWIW:


Reviewed-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>

Regards,
Lino