Re: vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()

From: SF Markus Elfring
Date: Fri May 12 2017 - 03:33:02 EST


>> Just because an automated tool says that this needs to change does not
>> mean it has to.
>
> Checkpatch.pl is correct here. This message is useless. It's during
> init so it's unlikely to fail ever. In current kernels small kmallocs
> are quaranteed to succeed so it can't actually fail currently. The
> stack trace is more useful than this message because it tells you a lot
> about what memory is free and the whole call tree.
>
> The error message is dead useless code.

Would you like to clarify corresponding software evolution any more?

Is there a need for better documentation of the involved programming interfaces?


> This patch is not going to be merged because Markus doesn't listen to
> feedback and he's blocked but otherwise it's an OK patch.

Does this information contain a contradiction?
Will patches be picked up also from contributors who got a special
development reputation anyhow?

Regards,
Markus