Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

From: David Miller
Date: Fri May 12 2017 - 12:22:31 EST


From: Julia Lawall <julia.lawall@xxxxxxx>
Date: Fri, 12 May 2017 22:54:23 +0800 (SGT)

> Device node iterators put the previous value of the index variable, so an
> explicit put causes a double put.
...
> @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev,
> if (r) {
> mdiobus_free(cb->mii_bus);
> devm_kfree(dev, cb);
> - of_node_put(child_bus_node);
> } else {

I think we're instead simply missing a break; statement here.