Re: [PATCH v1] samples/bpf: Add a .gitignore for binaries

From: MickaÃl SalaÃn
Date: Sat May 13 2017 - 06:31:32 EST



On 13/02/2017 02:43, David Ahern wrote:
> On 2/12/17 2:23 PM, MickaÃl SalaÃn wrote:
>> diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
>> new file mode 100644
>> index 000000000000..a7562a5ef4c2
>> --- /dev/null
>> +++ b/samples/bpf/.gitignore
>> @@ -0,0 +1,32 @@
>> +fds_example
>> +lathist
>
> ...
>
> Listing each target is going to be a PITA to maintain. It would be
> better to put targets into a build directory (bin?) and ignore the
> directory.
>

It would require a lot of modifications to the Makefile and more
complexity. It seems much more simple for everyone to stick to a simple
gitignore file easily maintainable:
$ awk '$1 == "hostprogs-y" { print $3 }' < Makefile > .gitignore

Alexei, Daniel, what do you think about this? Do you want me to send a
v2 with the new tests?

MickaÃl

Attachment: signature.asc
Description: OpenPGP digital signature