Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

From: Andy Lutomirski
Date: Sat May 13 2017 - 08:32:53 EST


On Thu, May 11, 2017 at 9:06 PM, Andy Lutomirski <luto@xxxxxxxxxx> wrote:
> It seems like RSTe is much more conservative with transition timing
> that we are. According to Mario, RSTe programs APST to transition from
> active states to the first idle state after 60ms and, thereafter, to
> 1000 * the exit latency of the target state.

Bad news, folks: this appears to be merely more stable, not all the way stable:

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184/comments/65

I maintain my hypothesis that no one ever validated these disks and
that the very conservative parameters set by RSTe merely make it rare
to trigger the bug. But maybe something else is going on.