Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions

From: harinath Nampally
Date: Mon May 15 2017 - 00:38:59 EST

Next message: Leon Romanovsky: "Re: [PATCH] i2c: mux: only print failure message on error"
Previous message: harinath Nampally: "Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions"
In reply to: harinath Nampally: "Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Jonathan,

Thank you for letting me know about correct iio git tree.

I checked out 'togreg' branch, and noticed that
latest ade7758_core.c still has checkpatch.pl warnings.

Actually Quentin Swain fixed the similar warnings in the ade7854.c,
and my patch is fix for similar warnings but it is for different file
ade7758_core.c

Please correct me if I am wrong.

Thanks,
Harinath

On Mon, May 15, 2017 at 12:27 AM, harinath Nampally
<harinath922@xxxxxxxxx> wrote:
> Jonathan,
>
> Thank you for letting me know about correct iio git tree.
>
> I checked out 'togreg' branch, and noticed that
> latest ade7758_core.c still has checkpatch.pl warnings.
>
> Actually Quentin Swain fixed the similar warnings in the ade7854.c,
> and my patch is fix for similar warnings but it is for different file
> ade7758_core.c
>
> Please refer to below link for Quentin Swain's patch.
> https://www.spinics.net/lists/linux-iio/msg33010.html
>
> Please let me know if I am wrong.
>
> Thanks,
> Harinath
>
> On Mon, May 15, 2017 at 12:22 AM, harinath Nampally
> <harinath922@xxxxxxxxx> wrote:
>> Jonathan,
>>
>> Thank you for letting me know about correct iio git tree.
>>
>> I checked out 'togreg' branch, and noticed that
>> latest ade7758_core.c still has checkpatch.pl warnings.
>>
>> Actually Quentin Swain fixed the similar warnings in the ade7854.c,
>> and my patch is fix for similar warnings but it is for different file
>> ade7758_core.c
>>
>> Please refer to below link for Quentin Swain's patch.
>> https://www.spinics.net/lists/linux-iio/msg33010.html
>>
>> Please let me know if I am wrong.
>>
>> Thanks,
>> Harinath
>>
>> On Sun, May 14, 2017 at 10:41 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>>>
>>> On 12/05/17 22:19, Harinath Nampally wrote:
>>>>
>>>> This patch fixes below kind of warnings:
>>>> WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred.
>>>>
>>>> Issue found and fixed by checkpatch.pl
>>>>
>>>> Signed-off-by: Harinath Nampally <harinath922@xxxxxxxxx>
>>>
>>> Already done by Quentin Swain <dudebrobro179@xxxxxxxxx> last month...
>>>
>>> For IIO related patches, stuff gets queued up in iio.git on
>>> kernel.org before it gets sent on to Greg. This is relatively
>>> unusual for staging, but does lead to lots of repeats of
>>> patches like this unfortunately.
>>>
>>> Jonathan
>>>
>>>> ---
>>>> drivers/staging/iio/meter/ade7758_core.c | 50
>>>> ++++++++++++++++----------------
>>>> 1 file changed, 25 insertions(+), 25 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/iio/meter/ade7758_core.c
>>>> b/drivers/staging/iio/meter/ade7758_core.c
>>>> index 99c89e6..40498af 100644
>>>> --- a/drivers/staging/iio/meter/ade7758_core.c
>>>> +++ b/drivers/staging/iio/meter/ade7758_core.c
>>>> @@ -301,103 +301,103 @@ static int ade7758_reset(struct device *dev)
>>>> return ret;
>>>> }
>>>> -static IIO_DEV_ATTR_VPEAK(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_VPEAK(0644,
>>>> ade7758_read_8bit,
>>>> ade7758_write_8bit,
>>>> ADE7758_VPEAK);
>>>> -static IIO_DEV_ATTR_IPEAK(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_IPEAK(0644,
>>>> ade7758_read_8bit,
>>>> ade7758_write_8bit,
>>>> ADE7758_VPEAK);
>>>> -static IIO_DEV_ATTR_APHCAL(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_APHCAL(0644,
>>>> ade7758_read_8bit,
>>>> ade7758_write_8bit,
>>>> ADE7758_APHCAL);
>>>> -static IIO_DEV_ATTR_BPHCAL(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_BPHCAL(0644,
>>>> ade7758_read_8bit,
>>>> ade7758_write_8bit,
>>>> ADE7758_BPHCAL);
>>>> -static IIO_DEV_ATTR_CPHCAL(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_CPHCAL(0644,
>>>> ade7758_read_8bit,
>>>> ade7758_write_8bit,
>>>> ADE7758_CPHCAL);
>>>> -static IIO_DEV_ATTR_WDIV(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_WDIV(0644,
>>>> ade7758_read_8bit,
>>>> ade7758_write_8bit,
>>>> ADE7758_WDIV);
>>>> -static IIO_DEV_ATTR_VADIV(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_VADIV(0644,
>>>> ade7758_read_8bit,
>>>> ade7758_write_8bit,
>>>> ADE7758_VADIV);
>>>> -static IIO_DEV_ATTR_AIRMS(S_IRUGO,
>>>> +static IIO_DEV_ATTR_AIRMS(0444,
>>>> ade7758_read_24bit,
>>>> NULL,
>>>> ADE7758_AIRMS);
>>>> -static IIO_DEV_ATTR_BIRMS(S_IRUGO,
>>>> +static IIO_DEV_ATTR_BIRMS(0444,
>>>> ade7758_read_24bit,
>>>> NULL,
>>>> ADE7758_BIRMS);
>>>> -static IIO_DEV_ATTR_CIRMS(S_IRUGO,
>>>> +static IIO_DEV_ATTR_CIRMS(0444,
>>>> ade7758_read_24bit,
>>>> NULL,
>>>> ADE7758_CIRMS);
>>>> -static IIO_DEV_ATTR_AVRMS(S_IRUGO,
>>>> +static IIO_DEV_ATTR_AVRMS(0444,
>>>> ade7758_read_24bit,
>>>> NULL,
>>>> ADE7758_AVRMS);
>>>> -static IIO_DEV_ATTR_BVRMS(S_IRUGO,
>>>> +static IIO_DEV_ATTR_BVRMS(0444,
>>>> ade7758_read_24bit,
>>>> NULL,
>>>> ADE7758_BVRMS);
>>>> -static IIO_DEV_ATTR_CVRMS(S_IRUGO,
>>>> +static IIO_DEV_ATTR_CVRMS(0444,
>>>> ade7758_read_24bit,
>>>> NULL,
>>>> ADE7758_CVRMS);
>>>> -static IIO_DEV_ATTR_AIRMSOS(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_AIRMSOS(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_AIRMSOS);
>>>> -static IIO_DEV_ATTR_BIRMSOS(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_BIRMSOS(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_BIRMSOS);
>>>> -static IIO_DEV_ATTR_CIRMSOS(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_CIRMSOS(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_CIRMSOS);
>>>> -static IIO_DEV_ATTR_AVRMSOS(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_AVRMSOS(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_AVRMSOS);
>>>> -static IIO_DEV_ATTR_BVRMSOS(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_BVRMSOS(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_BVRMSOS);
>>>> -static IIO_DEV_ATTR_CVRMSOS(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_CVRMSOS(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_CVRMSOS);
>>>> -static IIO_DEV_ATTR_AIGAIN(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_AIGAIN(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_AIGAIN);
>>>> -static IIO_DEV_ATTR_BIGAIN(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_BIGAIN(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_BIGAIN);
>>>> -static IIO_DEV_ATTR_CIGAIN(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_CIGAIN(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_CIGAIN);
>>>> -static IIO_DEV_ATTR_AVRMSGAIN(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_AVRMSGAIN(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_AVRMSGAIN);
>>>> -static IIO_DEV_ATTR_BVRMSGAIN(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_BVRMSGAIN(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_BVRMSGAIN);
>>>> -static IIO_DEV_ATTR_CVRMSGAIN(S_IWUSR | S_IRUGO,
>>>> +static IIO_DEV_ATTR_CVRMSGAIN(0644,
>>>> ade7758_read_16bit,
>>>> ade7758_write_16bit,
>>>> ADE7758_CVRMSGAIN);
>>>>
>>>
>>
>>
>>
>> --
>> Thanks,
>> Harinath
>> +1 312 560 8565
>>
>>
>
>
>
> --
> Thanks,
> Harinath
> +1 312 560 8565

--
Thanks,
Harinath
+1 312 560 8565

Next message: Leon Romanovsky: "Re: [PATCH] i2c: mux: only print failure message on error"
Previous message: harinath Nampally: "Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions"
In reply to: harinath Nampally: "Re: [PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]